Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use Nathan's CCDB fork #76

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Sep 9, 2024

This PR switches the CCDB submodule to use @baltzell's fork of CCDB, which is the version we use in other CLAS12 software.

@c-dilks c-dilks marked this pull request as ready for review September 9, 2024 21:18
@baltzell
Copy link
Collaborator

We'll get this upstream by the end of the year, meanwhile, yes, need that fork.

@dglazier
Copy link
Collaborator

Hi @c-dilks , @baltzell
Should I go ahead and merge the pul request with master at the moment? Or should we wait until the ccdb module is linked to a JeffersonLab project ?
Cheers
Derek

@baltzell
Copy link
Collaborator

Or should we wait until the ccdb module is linked to a JeffersonLab project ?

That could be a long time off ...

@c-dilks
Copy link
Member Author

c-dilks commented Sep 20, 2024

Should I go ahead and merge the pul request with master at the moment?

Yes, as long as things still work here. The CI test passes, at least.

@dglazier dglazier merged commit 4ddf6f6 into JeffersonLab:master Sep 24, 2024
1 check passed
@c-dilks c-dilks deleted the ccdb-nathan branch September 24, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants