External hipo

[dglazier]

Provisional changes for using external hipo

[c-dilks]

Here are HIPO builder steps you can adapt for your CI workflow:

      - name: checkout hipo
        uses: actions/checkout@v4
        with:
          repository: gavalian/hipo
          ref: 4.0.1 # if you want to use a fixed tag; remove if you want to use `main`
          path: hipo_src

      - name: build hipo
        run: |
          cmake -S hipo_src -B hipo_build --install-prefix $HIPO  # you might prefer a different prefix
          cmake --build hipo_build -j4
          cmake --install hipo_build

[c-dilks]

Did you mean dictionary.h here?

Suggested change

	#include <hipo4/bank.h>
	#include <hipo4/dictionary.h>

[c-dilks]

Suggested change

	#include <hipo4/bank.h>
	#include <hipo4/dictionary.h>

[c-dilks]

Suggested change

	#include <hipo4/bank.h>
	#include <hipo4/dictionary.h>

[c-dilks]

Suggested change

	#include <hipo4/bank.h>
	#include <hipo4/dictionary.h>

[c-dilks]

Suggested change

	#include <hipo4/bank.h>
	#include <hipo4/dictionary.h>

[c-dilks]

Will these library loads still be needed, regardless of whether or not they are externally built?

[c-dilks]

$ENV{HIPO}? Or instruct users to set -DCMAKE_PREFIX_PATH?

[c-dilks]

These variables aren't needed since the PkgConfig::hipo4 target can be used.

Suggested change

	MESSAGE( STATUS "HIPO4 INCLUDE_DIR : " ${hipo4_INCLUDE_DIRS} )
	MESSAGE( STATUS "HIPO4 LIBRARIES : " ${hipo4_LIBRARIES} )

[c-dilks]

I also had to modify Clas12Root/src/CMakeLists.txt to include and link hipo4. Perhaps not all of the executables need it, but here's a change that got things working on my end:

--- a/Clas12Root/src/CMakeLists.txt
+++ b/Clas12Root/src/CMakeLists.txt
@@ -1,16 +1,20 @@
 set(CLAS12ROOT Clas12Root)

 add_executable (clas12root clas12root.cpp)
-target_link_libraries(clas12root  ${ROOT_LIBRARIES})
+target_link_libraries(clas12root  ${ROOT_LIBRARIES} PkgConfig::hipo4)
+target_include_directories(clas12root SYSTEM PUBLIC PkgConfig::hipo4)

 add_executable (clas12proof clas12proof.cpp)
-target_link_libraries(clas12proof ${ROOT_LIBRARIES})
+target_link_libraries(clas12proof ${ROOT_LIBRARIES} PkgConfig::hipo4)
+target_include_directories(clas12proof SYSTEM PUBLIC PkgConfig::hipo4)

 add_executable (particleDraw particleDraw.cpp)
-target_link_libraries(particleDraw ${ROOT_LIBRARIES})
+target_link_libraries(particleDraw ${ROOT_LIBRARIES} PkgConfig::hipo4)
+target_include_directories(particleDraw SYSTEM PUBLIC PkgConfig::hipo4)

 add_executable (particleTree particleTree.cpp)
-target_link_libraries(particleTree ${ROOT_LIBRARIES})
+target_link_libraries(particleTree ${ROOT_LIBRARIES} PkgConfig::hipo4)
+target_include_directories(particleTree SYSTEM PUBLIC PkgConfig::hipo4)
 install (TARGETS clas12root clas12proof particleDraw particleTree DESTINATION ${CMAKE_INSTALL_BINDIR})

 add_executable (makeHipoSelector makeHipoSelector.cpp)

[c-dilks]

Perhaps the hipo4/ subdirectory can be removed, since those files appear to be an older version.