Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: automatically get list of datasets to check #43

Merged
merged 5 commits into from
Oct 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,33 @@ concurrency:

jobs:

# get list of datasets to check
get_datasets:
runs-on: ubuntu-latest
outputs:
datasets: ${{ steps.datasets.outputs.datasets }}
steps:
- name: checkout
uses: actions/checkout@v3
- name: get data sets
id: datasets
working-directory: qadb
run: |
ls -d pass*/* | jq -Rs '{"dataset": split("\n")[:-1]}' > list.json
echo "### List of Datasets" >> $GITHUB_STEP_SUMMARY
echo '```json' >> $GITHUB_STEP_SUMMARY
cat list.json | xargs -0 -I{} echo {} >> $GITHUB_STEP_SUMMARY
echo '```' >> $GITHUB_STEP_SUMMARY
echo datasets=$(jq -c . list.json) >> $GITHUB_OUTPUT

# check consistency between Groovy and C++ APIs
groovy_vs_cpp:
needs:
- get_datasets
runs-on: ubuntu-latest
strategy:
fail-fast: true
matrix:
dataset:
- pass1/rga_fa18_inbending
- pass1/rga_fa18_outbending
- pass1/rga_sp19
- pass1/rgb_fa19
- pass1/rgb_sp19
- pass1/rgb_wi20
- pass1/rgk_fa18_6.5GeV
- pass1/rgk_fa18_7.5GeV
matrix: ${{ fromJson(needs.get_datasets.outputs.datasets) }}
steps:
- name: checkout
uses: actions/checkout@v3
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,6 @@ Documentation for QADB maintenance and revision
* run `bin/makeTables.sh`
* run `bin/makeTextFiles.sh`
* update customized QA criteria sets, such as `OkForAsymmetry`
* add any new dataset to the CI tests: `.github/workflows/ci.yml`
* add/update a symlink to this dataset in `qadb/latest`, if this is a new Pass
* update the above table of data sets
* use `git status` and `git diff` to review changes, then add and commit to
Expand Down