Support nested array wildcard deletion #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Jeffail, it'd be great to have your thoughts on this PR. Thanks! |
|
Hey @jlourenc, I'll need to put some proper time aside to understand fully what's going on here but we'd also need to leave |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #95 by supporting wildcard deletes at all levels in a
Container's hierarchy.searchStricthas been refactored and renamed intosearchPathsto provide return parameters that are both useful forSearchandDeletemethods.The notion of path with its associated types
pathandpathshas been introduced to reflect the multiplicity of paths that wildcards introduce.