Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "row vectors" and simplify positional argument defaults #6

Merged
merged 3 commits into from
Nov 29, 2021

Conversation

JeffFessler
Copy link
Owner

@JeffFessler JeffFessler commented Nov 29, 2021

Also support N x 1 arrays.

Also switches to using Requires as suggested in #5

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #6 (765d95f) into main (eb2112c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         2    +1     
  Lines           12        13    +1     
=========================================
+ Hits            12        13    +1     
Impacted Files Coverage Δ
src/Sound.jl 100.00% <100.00%> (ø)
src/sample-buf.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b93eae...765d95f. Read the comment docs.

@JeffFessler JeffFessler mentioned this pull request Nov 29, 2021
@JeffFessler JeffFessler merged commit 239c4de into main Nov 29, 2021
@JeffFessler JeffFessler deleted the row branch November 29, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant