-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Create test module to test SPI #413
Conversation
Thanks, @kewne, there are many files changed by this PR. We appreciate your contribution, would you consider joining the JCP as an associate member if you plan to contribute on a similar scale more often? |
@keilw Most of the changes are copying files into the new module. In many cases we can probably remove the originals. I'm definitely interested in contributing to this and other projects as I can, I'll look into it. Thanks! |
@kewne That's fine, if you can, please mark the original files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the problem happens particularly with JPMS (Jigsaw) modularity, would it be possible to also declare a module-info for the test module?
@keilw Done, I've additionally moved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, could we call the module just module org.javamoney.moneta.test
?
@keilw I've renamed the module as requested. |
Adds a "test" module for testing the SPI.
The reason for this is that, due to the changes in how ServiceLoader works,
META-INF/services
files in test source trees are put in unnamed modules and thus cannot be accessed by the ServiceLoader in theorg.javamoney.moneta
module.This should fix the issues from #370.
This change is