made BinaryReader a bit more efficient

Jatie1 · Feb 14, 2022 · 40fc726 · 40fc726
1 parent cc7161d
commit 40fc726
Showing 1 changed file with 6 additions and 11 deletions.
diff --git a/src/main/java/com/jatie/BinaryReader.java b/src/main/java/com/jatie/BinaryReader.java
@@ -7,40 +7,35 @@ public class BinaryReader {
 
     public static int readInt(final DataInputStream is) throws IOException {
         int value = is.readInt();
-        int b1 = value & 0xff;
         int b2 = value >> 8 & 0xff;
         int b3 = value >> 16 & 0xff;
         int b4 = value >> 24 & 0xff;
 
-        return b1 << 24 | b2 << 16 | b3 << 8 | b4;
+        return value << 24 | b2 << 16 | b3 << 8 | b4;
     }
 
     public static void skipString(final DataInputStream is) throws IOException {
-        if (is.readByte() == 0) {
+        if (is.read() == 0) {
             return;
         }
         is.skip(getStringLength(is));
     }
 
     public static void skipString(final DataInputStream is, int num) throws IOException {
         for (; num > 0; num--) {
-            if (is.readByte() == 0) {
-                continue;
-            }
-            is.skip(getStringLength(is));
+            skipString(is);
         }
     }
 
     public static int getStringLength(final DataInputStream is) throws IOException {
         int count = 0;
         int shift = 0;
-        boolean more = true;
-        while (more) {
-            byte b = is.readByte();
+        while (true) {
+            int b = is.read();
             count |= (b & 0x7F) << shift;
             shift += 7;
             if ((b & 0x80) == 0) {
-                more = false;
+                break;
             }
         }
         return count;