[WIP] #338 - Update to Kotlin MPP plugin #341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consp1racy
reviewed
Feb 13, 2019
| @@ -26,9 +26,9 @@ android { | |||
| } | |||
|
|
|||
| dependencies { | |||
| api project(':jdk') | |||
| api project(':common') | |||
There was a problem hiding this comment.
Keep the jdk.
I just had an android library with just the common artifact and couldn't call anything until I added jdk as well. jdk artifact does some magic so the whole thing can be consumed by other java modules.
consp1racy
reviewed
Feb 13, 2019
| ext.versions = [ | ||
| 'minSdk': 9, | ||
| 'compileSdk': 28, | ||
| ext.versions = [ |
There was a problem hiding this comment.
Always keep the original code style. None of this is supposed to pollute the changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First stab at refactoring to MPP plugin(issue #338 ). Needs lots of work before production ready. Purpose of this PR is get a discussion started on how to proceed with multiple issues, and work towards a PR that can be merged. This refactor removes the old 4.x code (master has 4.x & 5.x in separate modules).
common module builds the jvm, js, ios (& other native possibly)
android module builds the android artifact
sample module contains android sample app
Here are issues that need resolved:
synchronizedin Timber.kt needs to find a multiplatform solution. Does not seem possible without a dependency on a library. Perhaps using a coroutine scope?com.moowork.gradle:gradle-node-plugin:1.2.0plugin conflicting with gradle 4.7. Currently setup with the 'de.solugo.gradle:gradle-nodejs-plugin:0.6.0', but that has error when running