Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag rustls-tls for custom ca feature #109

Conversation

Owen-CH-Leung
Copy link
Contributor

@Owen-CH-Leung Owen-CH-Leung commented Nov 10, 2023

Apology for the back-and-forth - As per the comment here, I learnt that the upstream project maturin creates the python wheels by using the feature flag rustls-tls. Hence this PR adds a tiny code change to include the feature flag rustls-tls for the custom ca feature.

The PR also addresses the comment here

@Owen-CH-Leung Owen-CH-Leung marked this pull request as ready for review November 11, 2023 12:09
src/ctx.rs Show resolved Hide resolved
@Jake-Shadle Jake-Shadle merged commit b9f8a1d into Jake-Shadle:main Nov 11, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants