Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudflared supports arm64 now #24

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Conversation

koush
Copy link
Contributor

@koush koush commented Aug 6, 2024

Copy link

changeset-bot bot commented Aug 6, 2024

⚠️ No Changeset found

Latest commit: 087d967

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@koush
Copy link
Contributor Author

koush commented Aug 6, 2024

tests seem to be pulling old versions where the arm64 binary doesn't exist.

@JacobLinCool
Copy link
Owner

Thanks. I've added a quick fix to fall back to x64 on older versions.

Can you try to run pnpm changeset to add it so I can give credit to you in the changelog?

@koush
Copy link
Contributor Author

koush commented Aug 6, 2024

Thanks. I've added a quick fix to fall back to x64 on older versions.

Can you try to run pnpm changeset to add it so I can give credit to you in the changelog?

just did this via a GitHub web ui so I don't even have a checkout. but don't need credit, thanks though.

@JacobLinCool JacobLinCool merged commit 652a7a7 into JacobLinCool:main Aug 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants