Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use shell to start process #22

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

koterpillar
Copy link
Contributor

This makes sure the executable name isn't parsed by the shell, avoiding errors when the executable path contains spaces or possibly other special characters.

Fixes #21

This makes sure the executable name isn't parsed by the shell, avoiding
errors when the executable path contains spaces or possibly other
special characters.
Copy link

changeset-bot bot commented Jun 11, 2024

🦋 Changeset detected

Latest commit: 2dc1efe

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JacobLinCool
Copy link
Owner

Thanks! I actually do not remember why I used shell: true there...

@JacobLinCool JacobLinCool merged commit ca105cc into JacobLinCool:main Jun 19, 2024
15 checks passed
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
@koterpillar koterpillar deleted the dont-use-shell-to-run branch June 24, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to install to a path with spaces
2 participants