-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Lychee link checker to user documentation #531
Conversation
We had the same idea at the same time 😅🙈 --> #532 I merged the two workflows to make it easier for contributors. WDYT? We can also split them again ^^ |
In case they use CloudFlare and we think the links are stable, we add it to |
Woah! Crazy. Sidenote: I have also been trying to set up the workflow to copy the check-links.yaml from the main Jabref/jabref repo when updated but I am severely limited by my GitHub workflow knowledge unfortunately, doesn't seem feasible for me given my time constraints at the moment lol. Chalk it up as an issue I guess. Here's the little I achieved (in new workflow called sync-check-links.yaml, not actually included in this PR because not nearly complete enough to push).
|
Re: splitting or combining the workflows I suppose what you lose is the ability to change the conditions for executing (i.e. the |
Yes! I was accepting that th emarkdown linter is running also periodically. All other triggers are the same. -- You can split the workflows again if you think its better -- because also the "play" button in the actions tab could be more intuitive. |
My two cents are I would keep it split as I think one workflow per seperate check looks nicer anyway. :) |
I'll merge your PR then. |
Sorry, removed the second one! |
You also need to remove th |
Thanks! Nice. Will now work on fixing the links a-la #533 :). |
Ported the Lychee link checker to user documentation as indicated here:
#526 (comment)
Example output of Lychee from running the workflow on my local branch
https://github.com/Tridecatrix/user-documentation/actions/runs/11379543940/attempts/1#summary-31657176353
Pretty much just copy pasted over the check-links.yml file and .lycheeignore for now. From a quick check of a selection of the links given by Lychee, it does seem to work, i.e. the links it says are broken are really broken. Except for one example I'll indicate further below.
Require feedback on:
As for that one example of a bad detection, it was this, which indicates a broken reference:
Even though the original code has none: