-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable triggering offline parsing explicitely #11565
Conversation
- Refactor actions to inheritance instead of if-statements in a class - Solved "fun" with inheritance and FXML - Use %0 and offline/offline parameterization - Rename "GROBID" to "Grobid"
build.gradle
Outdated
@@ -118,6 +118,7 @@ sourceSets { | |||
} | |||
|
|||
repositories { | |||
mavenLocal() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed mavenLocal()
to be able to load the patched version org.jabref:afterburner.fx:2.0.0-SNAPSHOT
.
Not required any more.
src/main/java/org/jabref/gui/bibtexextractor/BibtexExtractorViewModel.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/gui/bibtexextractor/ExtractBibtexDialog.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bad architectural changes
Rewritten, now we have an public void startParsing() {
if (onlineMode) {
startParsingOnline();
} else {
startParsingOffline();
}
} This is OK for me. |
|
||
Platform.runLater(() -> { | ||
input.requestFocus(); | ||
Button buttonParse = (Button) getDialogPane().lookupButton(parseButtonType); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to have this code here, because otherwise, I get
Caused by: java.lang.NullPointerException: Cannot invoke "javafx.scene.control.Button.setTooltip(javafx.scene.control.Tooltip)" because "buttonParse" is null
# Conflicts: # src/main/java/org/jabref/gui/actions/StandardActions.java # src/main/resources/l10n/JabRef_en.properties
ViewLoader.view(this) | ||
.controller(this) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why controller?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I thought, I could not it get to work without this... Strange. Removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NewLibraryFromPdfActionOffline / NewLibraryFromPdfActionOnline : Composition over inheritance.
@koppor promised to fix this in follow up pr.
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
New online/offline distinction more visible in the UI:
Library menu:
Button on toolbar still asks for permission:
If "Do not ask again" (and Yes)
Additionally:
Feature: clipboard contents now contained automatically:
(You also see here "online" and "offline" indication at the dialog title)
Feature itself is described at https://docs.jabref.org/collect/newentryfromplaintext.
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)