fixing test and adding comments

JPro-one · Dec 9, 2024 · 16e3921 · 16e3921
1 parent 98480e1
commit 16e3921
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/...age-manager/src/main/java/one/jpro/platform/image/manager/source/ImageSourceResource.java b/...age-manager/src/main/java/one/jpro/platform/image/manager/source/ImageSourceResource.java
@@ -73,6 +73,7 @@ public JSONObject toJSON() {
         try {
             URL resourceUrl = getClass().getResource(resourcePath);
             if (resourceUrl != null) {
+                // we don't access any stream here, so we don't need to close it
                 URLConnection conn = resourceUrl.openConnection();
                 json.put("modified", conn.getLastModified());
             }

diff --git a/...age-manager/src/test/java/one/jpro/platform/image/manager/source/ImageSourceFileTest.java b/...age-manager/src/test/java/one/jpro/platform/image/manager/source/ImageSourceFileTest.java
@@ -36,6 +36,7 @@ public void testToJson() {
         JSONObject json = new JSONObject();
         json.put("type", "ImageSourceFile");
         json.put("path", ImageUtils.escapeJson(testImageFile.getAbsolutePath()));
+        json.put("modified", testImageFile.lastModified());
 
         assertTrue(imageSource.toJSON().similar(json));
     }

diff --git a/...manager/src/test/java/one/jpro/platform/image/manager/source/ImageSourceResourceTest.java b/...manager/src/test/java/one/jpro/platform/image/manager/source/ImageSourceResourceTest.java
@@ -4,6 +4,8 @@
 import org.junit.jupiter.api.Test;
 
 import java.awt.image.BufferedImage;
+import java.net.URL;
+import java.net.URLConnection;
 
 import static org.junit.jupiter.api.Assertions.*;
 
@@ -30,12 +32,18 @@ void testIdentityHashValue_validResourcePath_returnsHash() {
     }
 
     @Test
-    void testToJson_returnsExpectedJson() {
+    void testToJson_returnsExpectedJson() throws Exception {
         ImageSourceResource resource = new ImageSourceResource("/testImage.png");
 
         JSONObject json = new JSONObject();
         json.put("type", "ImageSourceResource");
         json.put("resourcePath", "/testImage.png");
+        URL resourceUrl = getClass().getResource("/testImage.png");
+        if (resourceUrl != null) {
+            // we don't access any stream here, so we don't need to close it
+            URLConnection conn = resourceUrl.openConnection();
+            json.put("modified", conn.getLastModified());
+        }
         assertTrue(resource.toJSON().similar(json));
     }
 }