Docs theme change #158
Merged
Docs theme change #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Table row hover color not so "in your face" * Adjust page title and top left title * Leave some crap in css and conf.py to play around with, cleanup later
- Currently this commit shows what's furo's defaults!!! - No customization required when features.rst tables specify width and align (defaults are centered/not-full-width) - Leave CSS experiments in synadm.css commented out for now - CSS with this theme should rather go to conf.py html_theme_options light/dark_css_variables...
if the site header is too tall, it interferes with pretty much all elements of the site, slightly or very noticeably (e.g. when skipping to headers in pages) `navbar_align` being left is important at 960px width, because it just so happens to not cause that (at least with inclusive sans). this is tricky to get right though, opendyslexic needs header_links_before_dropdown to be 1 so it doesn't cause an overflow also hide the last link behind a "more" button to also reduce space taken up
most pages show more levels upon scrolling, which isn't much useful because there's usually only 1 header (h2?) before all the rest is subheaders (h3?)
This partially reverts commit e1dff9e.
|
Thanks for removing the furo theme adjustments in 12b41a7. The Anyway I'm just noting it here in case we ever need it because pydata theme decides to follow that default at some point. We can merge like this, less clutter in features.rst is good. |
|
(My review is still pending, I'm just doing other stuff right now) |
JacksonChen666
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #156