Reorganize getdata section of temperature_component.cpp #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpbond
approved these changes
Mar 24, 2022
| @@ -103,7 +103,7 @@ class TemperatureComponent : public IModelComponent { | |||
| double taudif; // interior ocean heat uptake time scale, yr | |||
| double tauksl; // sea-land heat exchange time scale, yr | |||
| double taukls; // land-sea heat exchange time scale, yr | |||
| unitval q2co2; // radiative forcing for atmospheric CO2 doubling (W/m2) | |||
There was a problem hiding this comment.
Oh no it has units and I need to add them!
There was a problem hiding this comment.
Removed it from a unitval because the math it is used in does not like the unitval, beforehand we had some code that basically extracted the unitval information and reassigned it as a const double which seemed uncessairy.
| @@ -180,7 +180,7 @@ void TemperatureComponent::setData( const string& varName, | |||
| volscl = data.getUnitval(U_UNITLESS); | |||
| } else if(varName == D_QCO2) { | |||
| H_ASSERT( data.date == Core::undefinedIndex(), "date not allowed" ); | |||
| q2co2 = data.getUnitval(U_UNDEFINED); | |||
There was a problem hiding this comment.
...because it's unitless I guess :)
|
@bpbond okay to merge? |
|
Yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address part of #586 re organizes how the output variables are returned