Build ip with gcc when using aocc as preferred compiler, bump ip to 5.1.0 #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
commented
Dec 5, 2024
climbfuji
changed the title
AlexanderRichert-NOAA
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Because
ipdoesn't build with the AMDaocccompilers, we switch to building it withgccfor that setup. While at it, bumpipto5.1.0and revert the workaround in theneptune-envtemplate.Testing
Tested locally on my laptop: compile the neptune-env template (without Python packages) with
[email protected]and verified thatipis built withgccand the module loaded correctly.Applications affected
None (
aoccis still experimental)Systems affected
None (
aoccis still experimental)Dependencies
None
Issue(s) addressed
Working towards #1330
Checklist
All dependency PRs/issues have been resolved and this PR can be merged.