Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix include merge variable substitution #23

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix include merge variable substitution #23

merged 1 commit into from
Jul 17, 2024

Conversation

matthewrmshin
Copy link
Collaborator

Description

Variable substitution did not work correctly at top level of include merge.

Issue(s) addressed

Fix #21.

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@matthewrmshin matthewrmshin added the bug Something is not working label Jul 8, 2024
@matthewrmshin matthewrmshin self-assigned this Jul 8, 2024
@matthewrmshin
Fix include merge variable substitution
0b724f2 
Variable substitution did not work correctly at top level of include merge.
@matthewrmshin matthewrmshin force-pushed the bugfix/include-merge-process-substitution branch from 0587378 to 0b724f2 Compare July 8, 2024 15:17
mikecooke77
mikecooke77 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@mikecooke77 mikecooke77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this locally using the new code in a local conda environment and can confirm it fixes the issue. Thanks for adding Matt.

@matthewrmshin matthewrmshin merged commit d6ed899 into JCSDA-internal:main Jul 17, 2024
4 checks passed
@matthewrmshin matthewrmshin deleted the bugfix/include-merge-process-substitution branch July 17, 2024 13:19
@matthewrmshin matthewrmshin added this to the 0.5.3 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecooke77 mikecooke77 mikecooke77 approved these changes

@yaswant yaswant Awaiting requested review from yaswant

@steoxley steoxley Awaiting requested review from steoxley

Assignees

@matthewrmshin matthewrmshin

Labels
bug Something is not working
Projects
None yet
Milestone
0.5.3
Development

Successfully merging this pull request may close these issues.

Variable substitution with merge
2 participants
@matthewrmshin @mikecooke77