Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include (local scope) variable with non-str value #19

Conversation

matthewrmshin
Copy link
Collaborator

@matthewrmshin matthewrmshin commented Nov 29, 2023

Allows include of local scope variable with non-str value. This is useful for passing the value of an anchor down to an include scope.

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

Allows include of local scope variable with non-str value. This is
useful for passing the value of an anchor down to an include scope.
@matthewrmshin matthewrmshin self-assigned this Nov 29, 2023
@matthewrmshin matthewrmshin added this to the 0.5.2 milestone Nov 29, 2023
Copy link
Collaborator

@steoxley steoxley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Just one typo spotted in the documentation.

# greet.yaml
say:
- hello: ${HELLO}
taregts: ${TARGETS} # Good, value used on its own
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"targets"

@matthewrmshin matthewrmshin merged commit 1acbc7f into JCSDA-internal:main Nov 29, 2023
4 checks passed
@matthewrmshin matthewrmshin deleted the feature/include-variables-object branch November 29, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants