Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/diagnostics list #27

Merged
merged 22 commits into from
Jul 9, 2024
Merged

Feature/diagnostics list #27

merged 22 commits into from
Jul 9, 2024

Conversation

brandonzhu09
Copy link
Contributor

@brandonzhu09 brandonzhu09 commented Jun 18, 2024

Description

Extended the application to display a list of diagnostics at a time given the attributes selected or not selected in the dropdown menu to constrain or broaden the diagnostics search. Separated the channel field to its own dropdown where its options are dynamically tied with the variable attribute. Also, rewrote unit tests for the Django API views, mainly the update_variable_option endpoint that was changed to accept new parameters (variable_name and channel).

Additional features:

  • Created Dockerfile and docker-compose configuration files to setup and run the evagram application with multi-container services, including the frontend, backend, and the Postgres database. Updated the Readme to provide instructions to run Evagram on Docker.

Issues addressed

#20

@tariqhamzeyssai
Copy link
Collaborator

@brandonzhu09 Is this ready for review?

@brandonzhu09
Copy link
Contributor Author

@brandonzhu09 Is this ready for review?

Yes, its ready!

docker-compose.yml Outdated Show resolved Hide resolved
@asewnath
Copy link
Collaborator

asewnath commented Jun 26, 2024

I don't know if you're also running into this problem, but if I run evagram_input (setting owner name to postgres and experiment name to a random name) I'm able to add plots to the database, but I don't see a new username in the dropdown menu

@brandonzhu09
Copy link
Contributor Author

I don't know if you're also running into this problem, but if I run evagram_input (setting owner name to postgres and experiment name to a random name) I'm able to add plots to the database, but I don't see a new username in the dropdown menu

Shouldn't that be the intended behavior? If we are adding new experiments under the same owner, it shouldn't create a new username in the dropdown menu.

@asewnath
Copy link
Collaborator

I don't know if you're also running into this problem, but if I run evagram_input (setting owner name to postgres and experiment name to a random name) I'm able to add plots to the database, but I don't see a new username in the dropdown menu

Shouldn't that be the intended behavior? If we are adding new experiments under the same owner, it shouldn't create a new username in the dropdown menu.

To clarify, when I run evagram_input with a new username, I see that new username in the database but it doesn't appear in evagram's dropdown menus. I'm wondering if you're also encountering this problem or if it's an issue on my end

@brandonzhu09
Copy link
Contributor Author

I just want to say here that I want to move forward with the bugfix for the cascading logic after this PR is merged into develop. I was working on the develop branch for the bugfix when I realized there were so many changes to the frontend logic that I would need to practically redo the bugfix with the new frontend in this PR. Let me know on your thoughts on how I should approach this!

@brandonzhu09
Copy link
Contributor Author

I don't know if you're also running into this problem, but if I run evagram_input (setting owner name to postgres and experiment name to a random name) I'm able to add plots to the database, but I don't see a new username in the dropdown menu

Shouldn't that be the intended behavior? If we are adding new experiments under the same owner, it shouldn't create a new username in the dropdown menu.

To clarify, when I run evagram_input with a new username, I see that new username in the database but it doesn't appear in evagram's dropdown menus. I'm wondering if you're also encountering this problem or if it's an issue on my end

@asewnath I was able to recreate the problem you mentioned and found how to resolve it. What you have to do is to stop the postgresql service running on the host machine, run docker compose, and then use evagram_input to input data on the postgresql service running on the docker container. Hope this helps!

Copy link
Collaborator

@tariqhamzeyssai tariqhamzeyssai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not personally tested this, but we can move forward and revisit any remaining issues that may spring up. Thanks @brandonzhu09 for heeding our comments. Great work!

@brandonzhu09 brandonzhu09 merged commit 3276e47 into develop Jul 9, 2024
2 checks passed
@brandonzhu09 brandonzhu09 deleted the feature/diagnostics_list branch July 9, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants