Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New cubed sphere 2 grid #96

Draft
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

mo-jonasganderton
Copy link

@mo-jonasganderton mo-jonasganderton commented Nov 21, 2024

This PR has been moved to ecmwf/atlas.

Description

Initial implementation of a new cubed sphere grid.

@odlomax and @wdeconinck can both have a look over to recommend any changes - I expect this will have changed once everything else has also been implemented.

Using this implementation generates the following lonlat points - n=12, red=tile0, purple=tile5, darkest point of each colour is tij=0, lightest point is tij=143. This matches the sequence of the points in the LFRic cubed sphere.
CubedSphere_3_0_2

Impact

Once everything else is also implemented, this makes the cubed sphere more maintainable.

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 64.23358% with 49 lines in your changes missing coverage. Please review.

Project coverage is 79.95%. Comparing base (e734e7a) to head (4e288ad).
Report is 161 commits behind head on develop.

Files with missing lines Patch % Lines
src/atlas/grid/detail/grid/CubedSphere2.cc 56.66% 26 Missing ⚠️
src/atlas/grid/detail/grid/CubedSphere2.h 58.33% 20 Missing ⚠️
src/tests/grid/test_cubedsphere_2.cc 88.46% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #96      +/-   ##
===========================================
- Coverage    80.02%   79.95%   -0.08%     
===========================================
  Files          857      834      -23     
  Lines        63498    64805    +1307     
===========================================
+ Hits         50817    51814     +997     
- Misses       12681    12991     +310     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants