Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Price cards #433

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shreya-paul-17
Copy link

Related Issue

Closes #395

Description

The buttons of price cards were previously not at a proper position. I have fixed that .

Not only the size of the 2nd card whose emphasis is more, the height got increased both at the top and bottom which was making it look uneven because of the margin property. The height should get increased in the top. Thus, the text got shifted in the top a bit so that it looked a bit raised in nature.

I also added the hover effect on the buttons of "Buy Now".

Thus, the price cards section got fixed entirely.

Screenshots (if applicable)

Original Updated
virtuo-learn virtuo-4

Checklist

  • My code adheres to the established style guidelines of the project.
  • I have included comments in areas that may be difficult to understand.
  • My changes have not introduced any new warnings.
  • I have conducted a self-review of my code.

Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
virtuo-learn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 3:58pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @shreya-paul-17! 🎉 Thank you for submitting your pull request for Virtuo-Learn. Our dedicated team will review it diligently.Your contribution is valuable and we appreciate your efforts to improve our project.

@shreya-paul-17
Copy link
Author

@JAYESHBATRA Please review my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fixing of the buttons in the Price cards
1 participant