Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icons Added in footer #269

Closed
wants to merge 3 commits into from
Closed

icons Added in footer #269

wants to merge 3 commits into from

Conversation

SadafKausar2025
Copy link
Contributor

@SadafKausar2025 SadafKausar2025 commented May 17, 2024 •
edited
Loading

Hi @JAYESHBATRA

Related Issue #260

Closes #260

Description

Added Section Name and icons in the Footer

Screenshots (if applicable)

original
Screenshot (1746)
Screenshot (1747)

updated

Screenshot (1748)
Screenshot (1749)

Checklist

  • My code adheres to the established style guidelines of the project.
  • I have included comments in areas that may be difficult to understand.
  • My changes have not introduced any new warnings.
  • I have conducted a self-review of my code.

@vercel Vercel
Copy link

vercel bot commented May 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
virtuo-learn ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2024 2:23pm

github-actions[bot]
github-actions bot reviewed May 17, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @SadafKausar2025! 🎉 Thank you for submitting your pull request for Virtuo-Learn. Our dedicated team will review it diligently.Your contribution is valuable and we appreciate your efforts to improve our project.

@SadafKausar2025
Copy link
Contributor Author

hi @JAYESH-BATRA
I have resolved the conflict .
can you please merge this PR?

@JAYESHBATRA
Copy link
Owner

@SadafKausar2025 Kindly resolve the conflicts and raise a new PR .

@SadafKausar2025
Copy link
Contributor Author

hello @JAYESHBATRA
please reopen the PR i will resolve the conflicts here

@JAYESHBATRA JAYESHBATRA reopened this May 19, 2024
@SadafKausar2025
Copy link
Contributor Author

Hii @JAYESHBATRA
Now I resolved the conflicts it's ok now

@JAYESHBATRA
Copy link
Owner

@SadafKausar2025
Kindly note that the changes you have made are causing the size of the navbar image to change, which is undesirable. Please fix this issue and then raise a PR.
image

@SadafKausar2025
Copy link
Contributor Author

ok I will fixed it and again raise PR

@SadafKausar2025 SadafKausar2025 deleted the footer branch May 20, 2024 05:44
@SadafKausar2025 SadafKausar2025 restored the footer branch May 20, 2024 06:03
@SadafKausar2025 SadafKausar2025 deleted the footer branch May 20, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@SadafKausar2025 SadafKausar2025

Labels
title needs formatting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Added the section Name and Icons
2 participants
@SadafKausar2025 @JAYESHBATRA