Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Improvement for Mobile and Tablets. #248

Closed
wants to merge 1 commit into from

Conversation

shaurya35
Copy link

Issue #215

Description

  • Added a new feature for mobile where the navigation bar is now located at the bottom of the screen instead of opening it from the hamburger menu
  • Decreased the opacity of the social icons so that the main content is more focused.

##Video

improvement-.virtuo.learn.mp4

Checklist

  • My code adheres to the established style guidelines of the project.
  • I have included comments in areas that may be difficult to understand.
  • My changes have not introduced any new warnings.
  • I have conducted a self-review of my code.

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
virtuo-learn ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 7:22pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @shaurya35! 🎉 Thank you for submitting your pull request for Virtuo-Learn. Our dedicated team will review it diligently.Your contribution is valuable and we appreciate your efforts to improve our project.

@shaurya35 shaurya35 changed the title Added a new bottom navigation bar for Mobile phones and tablets UI Improvement for Mobile and Tablets. May 14, 2024
@JAYESHBATRA
Copy link
Owner

@shaurya35 We've decided not to proceed with keeping the Navbar at the bottom. We apologize for any inconvenience caused, but it's not as visually appealing as we had hoped. Thank you for your understanding.

@JAYESHBATRA JAYESHBATRA mentioned this pull request May 15, 2024
5 tasks
@shaurya35
Copy link
Author

Hi @JAYESHBATRA happy to resolve this bug.

I need to confirm, do you want to keep the bottom navbar or remove it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants