Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Pendulum Simulation #135

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

JiyaGupta-cs
Copy link
Contributor

Closes #129

Description

The text labels of the sliders were not with the sliders because the function position() used in this code to place the slider works differently with the text() function
We couldn't do it by CSS.
It can be done by making the both the things work by using the same function using P5.JS
Moreover we could not change the position values in slider.position(width, height); manually because the top and left (x,y) indexes would vary with each mobile device
Therefore I fixed the issue using a different approach.

Screenshots (if applicable)

| Original | Updated |
| :
image

image
: | image |
| original screenshot | updated screenshot |

Checklist

  • My code adheres to the established style guidelines of the project.
  • I have included comments in areas that may be difficult to understand.
  • My changes have not introduced any new warnings.
  • I have conducted a self-review of my code.

Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
virtuo-learn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 7:39pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @JiyaGupta-cs! 🎉 Thank you for submitting your pull request for Virtuo-Learn. Our dedicated team will review it diligently.Your contribution is valuable and we appreciate your efforts to improve our project.

@JAYESHBATRA JAYESHBATRA merged commit 332b9ec into JAYESHBATRA:main Jan 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Sliders not in Sync With Text In Pendulum Simulation
2 participants