Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Sliders not in Sync With Text In Pendulum Simulation #129

Closed
5 of 6 tasks
JiyaGupta-cs opened this issue Jan 15, 2024 · 3 comments · Fixed by #135
Closed
5 of 6 tasks

[BUG] Sliders not in Sync With Text In Pendulum Simulation #129

JiyaGupta-cs opened this issue Jan 15, 2024 · 3 comments · Fixed by #135
Assignees
Labels
bug Something isn't working IWOC2024 Medium

Comments

@JiyaGupta-cs
Copy link
Contributor

Description

The text labels of the sliders are not with the sliders because the function position() used in this code to place the slider works differently with the text() function

Proposed Solution-

=> We can't do it by CSS.
=> It can be done by making the both the things work by using the same function using P5.JS
=> Moreover, we could not change the position values in slider.position(width, height); manually because the top and left (x,y) indexes would vary with each mobile device
=> Therefore I fixed the issue using a different approach.

Screenshots

Desktop View -

image

Mobile View -

image

Any additional information?

No response

What browser are you seeing the problem on?

No response

Checklist

  • I have starred the repository
  • I have checked the existing issues
  • I have read the discussion tab thoroughly and got the project idea
  • I am willing to work on this issue (optional)
  • I am a SWOC'24 contributor
  • I am an IWOC 2.0 contributor
@JiyaGupta-cs JiyaGupta-cs added the bug Something isn't working label Jan 15, 2024
Copy link

Congratulations, @JiyaGupta-cs! 🎉 Thank you for creating your issue for Virtuo-Learn. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work! Should you have any queries or require guidance, do not hesitate to ask.

@JiyaGupta-cs
Copy link
Contributor Author

@JAYESHBATRA Please assign me this issue under IWOC

@JiyaGupta-cs
Copy link
Contributor Author

@JAYESHBATRA Please see the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working IWOC2024 Medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants