Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NftMinter support, error handling, other fixes #52

Merged
merged 34 commits into from
Sep 22, 2023
Merged

NftMinter support, error handling, other fixes #52

merged 34 commits into from
Sep 22, 2023

Conversation

bucurdavid
Copy link
Member

No description provided.

bucurdavid and others added 30 commits September 11, 2023 11:23
@bucurdavid
fix: custom errors extends error base class
61bf2cc 
Refs: #25
@bucurdavid
refactor: implement error handling classes
8550236 
Refs: #25
@bucurdavid
refactor: implement custom error class for marketplace
4a61fa4 
Refs: #25
@bucurdavid
refactor: implement custom error class handle for minter
5606d14 
Refs: #25
@bucurdavid
refactor: implement error handles for common methods
0255cbe 
Refs: #25
@bucurdavid
fix: royalties should have two decimals
3a6e3d5 
Refs: #47
@bucurdavid
chore: update dependecies
570d4f6 
Refs: #40
@bucurdavid
refactor!: implement minter base class
c5639d5 
BREAKING CHANGE: NftMinter and SftMinter will inherit from Minter class.
DataNftMinter -> SftMinter

Refs: #37
@bucurdavid
feat: pause and unpause transactions implementation
53938ef 
Refs: #37
@bucurdavid
feat: nft minter contract admin endpoints implementation
793f1e1 
Refs: #37
@bucurdavid
feat: updateAttributes && initializeContract methods implementation
71b69cf 
Refs: #37
@bucurdavid
refactor: abi file import in subclass and use in subclass constructor
01b2a56 
Refs: #37
@bucurdavid
refactor: abstract minter class
fe44d01
@bucurdavid
feat: collection management transaction implementation
1094fe8 
Refs: #37
@bucurdavid
refactor: different mint implementation based on subclass
fa45512 
Refs: #37
@bucurdavid
refactor: shared methods implemented in base class
d868534 
Refs :#37
@bucurdavid
view method for contract configuration
f9a3b5c 
Refs: #37
@bucurdavid
view methods of the contracts
53bc4b1 
Refs: #37
@bucurdavid
docs: constructor documentation for subclasses
09ed5be 
Refs: #37
@bucurdavid
refactor: gas limits and types
9628528 
Refs: #37
@newbreedofgeek
Merge pull request #51 from Itheum/develop
e229f9c 
MAIN : Automatic GitHub pages for TypeDoc
@bucurdavid
feat: claims address on initialize method
ca226e2 
Refs: #37
@bucurdavid
refactor: update abi
895ad33 
Refs: #37
@bucurdavid
feat: devnet2 support
7e2459b 
Refs: #37
@bucurdavid
Merge branch 'main' into d-david
f69f1db
@bucurdavid
merged errors
8c5f36e
@bucurdavid
refactor: error handling
9523077 
Refs: #25
@bucurdavid
refactor: error handling
0d1eed7 
Refs: #25
@bucurdavid
tests: update minter class name
926c41e 
Refs: #38
@bucurdavid
refactor: consistent address parameter
7427c54 
Refs: #25
damienen
damienen requested changes Sep 21, 2023
View reviewed changes
src/common/mint-utils.ts Outdated Show resolved Hide resolved
src/common/mint-utils.ts Outdated Show resolved Hide resolved
src/common/mint-utils.ts Outdated Show resolved Hide resolved
src/common/mint-utils.ts Outdated Show resolved Hide resolved
src/common/utils.ts Show resolved Hide resolved
src/sft-minter.ts Outdated Show resolved Hide resolved
src/sft-minter.ts Outdated Show resolved Hide resolved
src/sft-minter.ts Outdated Show resolved Hide resolved
src/sft-minter.ts Outdated Show resolved Hide resolved
tests/minter.test.ts Outdated Show resolved Hide resolved
newbreedofgeek
newbreedofgeek approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@newbreedofgeek newbreedofgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to code review as most files show all changed. but approving anyways to do live tests

@newbreedofgeek newbreedofgeek merged commit c1b5e4b into develop Sep 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newbreedofgeek newbreedofgeek newbreedofgeek approved these changes

@damienen damienen damienen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bucurdavid @newbreedofgeek @damienen