Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Background Authentication Calls and handing of undefined on lock resumption #1555

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Enable Background Authentication Calls and handing of undefined on lock resumption #1555

merged 2 commits into from
Jan 21, 2025
+49 −43

Conversation

IsmaelMartinez
Copy link
Owner

@IsmaelMartinez IsmaelMartinez commented Jan 21, 2025 •
edited
Loading

  • Adding enableBackgroundCallsAuthentication config option to validate if this keeps the user authenticated for longer
  • Removing the writeUrlBlockLog function that use to log those requests into a file for debugging
  • Handling of UnhandledPromiseRejectionWarning: TypeError: Cannot read properties of undefined (reading 'webContents') at PowerMonitor.refresh (.../app/connectionManager/index.js:31:34)
  • Checking the tray status before trying to update the badge count

Fixes #1545. Might fix #1521, #1495 and #1357

@IsmaelMartinez
adding the enableBackgroundCallsAuthentication removing writeUrlBlock…
b1a18c5 
…Log, doing some check on the connectionManager and tray to ensure we don't get undefined values
@IsmaelMartinez
fixing code analisys complain
9cd657c
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@IsmaelMartinez IsmaelMartinez merged commit adf6adc into main Jan 21, 2025
12 checks passed
@IsmaelMartinez IsmaelMartinez mentioned this pull request Jan 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass oauth token obtained from another machine [Bug]: Uncaught Exception: Tray is destroyed
1 participant
@IsmaelMartinez