-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RxSwift / RxCocoa update to 5.1.1 / Deployment Target to 10.0 #175
Open
John-Wolfe-Bose
wants to merge
14
commits into
IntrepidPursuits:master
Choose a base branch
from
John-Wolfe-Bose:wolfe/rxSwift-5.1.1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f3bd7e2
Updated Podfile
John-Wolfe-Bose 5d55dec
Result of running ‘pod __1.9.3__ install’
John-Wolfe-Bose c322d8d
Updated running swiftlint to check globally, then locally (in Pods), …
John-Wolfe-Bose 4dc8c16
Xcode 11.5 Recommended Project Settings
John-Wolfe-Bose 3566b0f
Fixed SwiftLint warning: orphaned_doc_comment
John-Wolfe-Bose 92ad5ae
Variable replaced with BehaviorRelay, E replaced with Element (RxSwif…
John-Wolfe-Bose c915642
Fixed SwiftRx Error around DispatchTimeInterval
John-Wolfe-Bose 9273171
Fixed RxSwift warning: 'next' is deprecated
John-Wolfe-Bose b847a2b
Update Intrepid Podspec to 0.16.0, Deployment Target to iOS 12.0
John-Wolfe-Bose 099d79e
Update IntrepidTesting podspec to 0.11.0
John-Wolfe-Bose 5564d90
Add ignoring of .DS_Store files
John-Wolfe-Bose 5cb78ef
Downgrade Deployment Target to 10.0, as per request
John-Wolfe-Bose 7837585
Removed commented out variable code (variable deprecated for RxSwift …
John-Wolfe-Bose e07c728
Renamed altered variable (not BehaviorRelay) unit tests, removing dup…
John-Wolfe-Bose File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,3 +49,4 @@ Carthage/Build | |
|
||
fastlane/report.xml | ||
fastlane/screenshots | ||
.DS_Store |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
Pod::Spec.new do |s| | ||
s.name = "IntrepidTesting" | ||
s.version = "0.10.0" | ||
s.version = "0.11.0" | ||
s.summary = "A collection of test extensions to the Swift Standard Library" | ||
s.description = <<-DESC | ||
Collection of test extensions and utility classes by and for the developers at Intrepid Pursuits. | ||
|
@@ -10,11 +10,11 @@ Pod::Spec.new do |s| | |
s.authors = { "Colden Prime" => "[email protected]" } | ||
s.source = { :git => "https://github.com/IntrepidPursuits/swift-wisdom.git", :tag => "#{s.version}" } | ||
s.platform = :ios | ||
s.ios.deployment_target = "8.0" | ||
s.ios.deployment_target = "12.0" | ||
s.pod_target_xcconfig = { 'SWIFT_VERSION' => '4.0' } | ||
s.default_subspec = "Core" | ||
s.swift_versions = ['4.2', '5.0'] | ||
|
||
s.subspec "Core" do |cs| | ||
cs.frameworks = "XCTest" | ||
cs.source_files = "SwiftWisdomTests/Testing/**/*.swift" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,30 +1,39 @@ | ||
PODS: | ||
- IP-UIKit-Wisdom (0.0.10) | ||
- RxCocoa (4.5.0): | ||
- RxSwift (>= 4.4.2, ~> 4.4) | ||
- RxSwift (4.5.0) | ||
- RxTest (4.5.0): | ||
- RxSwift (>= 4.4.2, ~> 4.4) | ||
- RxCocoa (5.1.1): | ||
- RxRelay (~> 5) | ||
- RxSwift (~> 5) | ||
- RxRelay (5.1.1): | ||
- RxSwift (~> 5) | ||
- RxSwift (5.1.1) | ||
- RxTest (5.1.1): | ||
- RxSwift (~> 5) | ||
- SwiftLint (0.40.0) | ||
|
||
DEPENDENCIES: | ||
- IP-UIKit-Wisdom | ||
- RxCocoa (~> 4.5) | ||
- RxSwift (~> 4.5) | ||
- RxTest (~> 4.5) | ||
- RxCocoa (~> 5.1.1) | ||
- RxSwift (~> 5.1.1) | ||
- RxTest (~> 5.1.1) | ||
- SwiftLint (~> 0.40.0) | ||
|
||
SPEC REPOS: | ||
https://github.com/cocoapods/specs.git: | ||
https://github.com/CocoaPods/Specs.git: | ||
- IP-UIKit-Wisdom | ||
- RxCocoa | ||
- RxRelay | ||
- RxSwift | ||
- RxTest | ||
- SwiftLint | ||
|
||
SPEC CHECKSUMS: | ||
IP-UIKit-Wisdom: b395a065344071b33659e5f6b918043a97c48a44 | ||
RxCocoa: cbf70265dc65a981d4ac982e513c10cf23df24a0 | ||
RxSwift: f172070dfd1a93d70a9ab97a5a01166206e1c575 | ||
RxTest: 3ccb66bfbace0bf7df1c43a7c75d046f8ce60372 | ||
RxCocoa: 32065309a38d29b5b0db858819b5bf9ef038b601 | ||
RxRelay: d77f7d771495f43c556cbc43eebd1bb54d01e8e9 | ||
RxSwift: 81470a2074fa8780320ea5fe4102807cb7118178 | ||
RxTest: 711632d5644dffbeb62c936a521b5b008a1e1faa | ||
SwiftLint: 4154893c73a4c52d6240195507eb7a3e3c64087e | ||
|
||
PODFILE CHECKSUM: afd51654925ed213b6b02f072f7fa09392e041f0 | ||
PODFILE CHECKSUM: 0b3531c5beefee7d976b641bf2b0ce80f252be63 | ||
|
||
COCOAPODS: 1.6.1 | ||
COCOAPODS: 1.9.3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,45 +25,61 @@ infix operator <-> : Binding | |
infix operator <- : Binding | ||
infix operator >>> : Disposing | ||
|
||
public func <- <T: ObserverType, O: ObservableType>(observer: T, observable: O) -> Disposable where T.E == O.E { | ||
public func <- <T: ObserverType, O: ObservableType>(observer: T, observable: O) -> Disposable where T.Element == O.Element { | ||
return observable.observeOn(MainScheduler.instance).bind(to: observer) | ||
} | ||
|
||
public func <- <T: ObserverType, O: ObservableType>(observer: T, observable: O) -> Disposable where T.E == O.E? { | ||
public func <- <T: ObserverType, O: ObservableType>(observer: T, observable: O) -> Disposable where T.Element == O.Element? { | ||
return observable.observeOn(MainScheduler.instance).bind(to: observer) | ||
} | ||
|
||
public func <- <T: ObserverType, O>(observer: T, variable: Variable<O>) -> Disposable where T.E == O { | ||
return observer <- variable.asObservable() | ||
public func <- <T: ObserverType, O>(observer: T, variable: O) -> Disposable where T.Element == O { | ||
return observer <- BehaviorRelay(value: variable) | ||
} | ||
|
||
public func <- <T: ObserverType, O>(observer: T, variable: Variable<O>) -> Disposable where T.E == O? { | ||
return observer <- variable.asObservable() | ||
public func <- <T: ObserverType, O>(observer: T, variable: O) -> Disposable where T.Element == O? { | ||
return observer <- BehaviorRelay(value: variable) | ||
} | ||
|
||
public func <- <T, O: ObservableType>(variable: Variable<T>, observable: O) -> Disposable where O.E == T { | ||
return observable.bind(to: variable) | ||
} | ||
//public func <- <T, O: ObservableType>(variable: T, observable: O) -> Disposable where O.Element == T { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a reason to comment out this code rather than just deleting it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just my paranoia - but the commented out code is deleted now |
||
// return variable <- observable.asObservable() | ||
//} | ||
|
||
public func <- <T>(observer: Variable<T>, observable: Variable<T>) -> Disposable { | ||
public func <- <T>(observer: BehaviorRelay<T>, observable: BehaviorRelay<T>) -> Disposable { | ||
return observer <- observable.asObservable() | ||
} | ||
|
||
public func <- <T: ObserverType, O>(observer: T, behaviorRelay: BehaviorRelay<O>) -> Disposable where T.E == O { | ||
//public func <- <T: ObserverType, O>(observer: T, variable: Variable<O>) -> Disposable where T.Element == O { | ||
// return observer <- variable.asObservable() | ||
//} | ||
// | ||
//public func <- <T: ObserverType, O>(observer: T, variable: Variable<O>) -> Disposable where T.Element == O? { | ||
// return observer <- variable.asObservable() | ||
//} | ||
// | ||
//public func <- <T, O: ObservableType>(variable: Variable<T>, observable: O) -> Disposable where O.Element == T { | ||
// return observable.bind(to: variable) | ||
//} | ||
// | ||
//public func <- <T>(observer: Variable<T>, observable: Variable<T>) -> Disposable { | ||
// return observer <- observable.asObservable() | ||
//} | ||
|
||
public func <- <T: ObserverType, O>(observer: T, behaviorRelay: BehaviorRelay<O>) -> Disposable where T.Element == O { | ||
return observer <- behaviorRelay.asObservable() | ||
} | ||
|
||
public func <- <T: ObserverType, O>(observer: T, behaviorRelay: BehaviorRelay<O>) -> Disposable where T.E == O? { | ||
public func <- <T: ObserverType, O>(observer: T, behaviorRelay: BehaviorRelay<O>) -> Disposable where T.Element == O? { | ||
return observer <- behaviorRelay.asObservable() | ||
} | ||
|
||
public func <- <T, O: ObservableType>(behaviorRelay: BehaviorRelay<T>, observable: O) -> Disposable where O.E == T { | ||
public func <- <T, O: ObservableType>(behaviorRelay: BehaviorRelay<T>, observable: O) -> Disposable where O.Element == T { | ||
return observable.bind(to: behaviorRelay) | ||
} | ||
|
||
public func <- <T>(observer: BehaviorRelay<T>, observable: BehaviorRelay<T>) -> Disposable { | ||
return observer <- observable.asObservable() | ||
} | ||
//public func <- <T>(observer: BehaviorRelay<T>, observable: BehaviorRelay<T>) -> Disposable { | ||
// return observer <- observable.asObservable() | ||
//} | ||
|
||
public func >>> (disposable: Disposable, disposeBag: DisposeBag) { | ||
disposeBag.insert(disposable) | ||
|
@@ -79,22 +95,22 @@ public func >>> (disposable: Disposable, compositeDisposable: CompositeDisposabl | |
// Created by Krunoslav Zaher on 12/6/15. | ||
// Copyright © 2015 Krunoslav Zaher. All rights reserved. | ||
// https://github.com/ReactiveX/RxSwift/blob/master/RxExample/RxExample/Operators.swift | ||
public func <-> <T>(property: ControlProperty<T>, variable: Variable<T>) -> Disposable { | ||
let bindToUIDisposable = variable | ||
.asObservable() | ||
.bind(to: property) | ||
let bindToVariable = property | ||
.subscribe( | ||
onNext: { next in | ||
variable.value = next | ||
}, | ||
onCompleted: { | ||
bindToUIDisposable.dispose() | ||
} | ||
) | ||
|
||
return Disposables.create(bindToUIDisposable, bindToVariable) | ||
} | ||
//public func <-> <T>(property: ControlProperty<T>, variable: Variable<T>) -> Disposable { | ||
// let bindToUIDisposable = variable | ||
// .asObservable() | ||
// .bind(to: property) | ||
// let bindToVariable = property | ||
// .subscribe( | ||
// onNext: { next in | ||
// variable.value = next | ||
// }, | ||
// onCompleted: { | ||
// bindToUIDisposable.dispose() | ||
// } | ||
// ) | ||
// | ||
// return Disposables.create(bindToUIDisposable, bindToVariable) | ||
//} | ||
|
||
public func <-> <T>(property: ControlProperty<T>, behaviorRelay: BehaviorRelay<T>) -> Disposable { | ||
let bindToUIDisposable = behaviorRelay | ||
|
@@ -114,7 +130,7 @@ public func <-> <T>(property: ControlProperty<T>, behaviorRelay: BehaviorRelay<T | |
|
||
extension ObservableType { | ||
/// This function just exists to enable use of the trailing closure. | ||
public func subscribeNext(_ on: @escaping (E) -> Swift.Void) -> Disposable { | ||
public func subscribeNext(_ on: @escaping (Element) -> Swift.Void) -> Disposable { | ||
return subscribe(onNext: on) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have not yet done a full review pass, but just initially want to discuss why the deployment target is being increased. I know firsthand of some specific downstream apps that specifically require iOS 10 support (yes, I know that is generally overkill). So just want to think this through.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rolled back deployment_targets to 10.0