Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed test modules #5028

Merged
merged 4 commits into from
Dec 23, 2024
Merged

Renamed test modules #5028

merged 4 commits into from
Dec 23, 2024

Conversation

coot
Copy link
Contributor

@coot coot commented Dec 19, 2024

Description

  • socket: generalised simpleMuxCallback
  • ouroboros-network-framework: renamed modules in testlib
  • ouroboros-network-testing: renamed modules
  • ouroboros-network-protocols:testlib: renamed Utils module

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@coot coot requested a review from a team as a code owner December 19, 2024 06:05
@coot coot added the testing label Dec 19, 2024
@coot coot self-assigned this Dec 19, 2024
crocodile-dentist
crocodile-dentist approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@crocodile-dentist crocodile-dentist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coot coot added this pull request to the merge queue Dec 20, 2024
@coot coot removed this pull request from the merge queue due to a manual request Dec 20, 2024
@coot coot force-pushed the coot/renamed-test-modules branch from ebecd4a to 70959af Compare December 20, 2024 06:18
@coot coot enabled auto-merge December 20, 2024 06:18
@coot
ouroboros-network-protocols:testlib: renamed Utils module
7c70551 
`Test.Ouroboros.Network.Testing.Utils -> Test.Ouroboros.Network.Protocol.Utils`
@coot coot force-pushed the coot/renamed-test-modules branch from 70959af to 7c70551 Compare December 23, 2024 10:38
@coot coot added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit b9f970f Dec 23, 2024
13 checks passed
@coot coot deleted the coot/renamed-test-modules branch December 23, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crocodile-dentist crocodile-dentist crocodile-dentist approved these changes

@bolt12 bolt12 bolt12 approved these changes

Assignees

@coot coot

Labels
testing
Projects
Ouroboros Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coot @bolt12 @crocodile-dentist