Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved connection manager transition tests #5026

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Improved connection manager transition tests #5026

merged 4 commits into from
Dec 18, 2024

Conversation

coot
Copy link
Contributor

@coot coot commented Dec 17, 2024 •
edited
Loading

Description

  • connection manager coverage unit tests
  • testnet: connection manager transition tracer
  • testnet: use global ConnIdSupply

Related to #5021 & #5017.

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@coot
connection manager coverage unit tests
ad537a2 
Turn the unenforced property tests into enforced unit tests.
Also improve the transition coverage test to cover two sources of
transition events: from `traceTVar` installed in `newMutableConnState`
and a transition tracer.
@coot coot requested a review from a team as a code owner December 17, 2024 08:26
@coot coot self-assigned this Dec 17, 2024
@coot coot added testing connection-manager Issues / PRs related to connection-manager labels Dec 17, 2024
@coot
testnet: connection manager transition tracer
615371c 
Reinstanciate it, without it some tests are not effective.
@coot coot force-pushed the coot/testnet-connection-manager-transition-tracer branch 2 times, most recently from cbab13f to 7fb0adf Compare December 17, 2024 08:43
coot added 2 commits December 17, 2024 18:28
@coot
testnet: use global ConnIdSupply
86b10ba 
A global `ConnIdSupply` allows to to distinguish all connections based
on their `ConnId`.
@coot
Updated CHANGELOG.md files
cb000e8
@coot coot force-pushed the coot/testnet-connection-manager-transition-tracer branch from 7fb0adf to cb000e8 Compare December 17, 2024 17:29
@coot coot enabled auto-merge December 17, 2024 17:29
@coot coot added this pull request to the merge queue Dec 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 17, 2024
@coot coot added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 9ca8627 Dec 18, 2024
15 of 16 checks passed
@coot coot deleted the coot/testnet-connection-manager-transition-tracer branch December 18, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolt12 bolt12 bolt12 approved these changes

Assignees

@coot coot

Labels
connection-manager Issues / PRs related to connection-manager testing
Projects
Ouroboros Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coot @bolt12