Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coot/framework io tests #4702

Merged
merged 3 commits into from
Oct 27, 2023
Merged

coot/framework io tests #4702

merged 3 commits into from
Oct 27, 2023

Conversation

coot
Copy link
Contributor

@coot coot commented Oct 26, 2023

  • flake.nix: increase heap size for mux tests
  • framework-io-tests: run prop_send_recv on ephemeral port
  • framework-io-tests: code style

@coot coot requested a review from a team as a code owner October 26, 2023 08:18
@coot coot added testing CI Issues / PRs related to CI labels Oct 26, 2023
@coot coot force-pushed the coot/framework-io-tests branch from 02f46c1 to 345dd74 Compare October 26, 2023 08:27
@coot coot marked this pull request as draft October 27, 2023 08:09
Copy link
Contributor

@karknu karknu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just needs to specify Streaming.

coot added 2 commits October 27, 2023 12:46
This should make it possible to run multiple instances of the test in
paralel on the same  machine (e.g. hydra).

Thanks to @karknu for a `darwin` fix.
@coot coot force-pushed the coot/framework-io-tests branch from 345dd74 to 34361cd Compare October 27, 2023 10:51
@coot coot marked this pull request as ready for review October 27, 2023 10:57
@coot coot enabled auto-merge October 27, 2023 10:58
@coot coot added this pull request to the merge queue Oct 27, 2023
Merged via the queue into master with commit eefcc83 Oct 27, 2023
7 of 8 checks passed
@coot coot deleted the coot/framework-io-tests branch October 27, 2023 11:44
@coot coot self-assigned this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issues / PRs related to CI testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants