Merge pull request #5031 from IntersectMBO/coot/pacman

GHA: install system dependencies via pacman

.github/workflows/build.yml

@@ -31,22 +31,18 @@ jobs:
 
     steps:
 
+    - name: "Install System Dependencies via pacman (msys2)"
+      if: runner.os == 'Windows'
+      shell: 'C:/msys64/usr/bin/bash.exe -e {0}'
+      run: |
+        /usr/bin/pacman -S --noconfirm mingw-w64-x86_64-pkg-config mingw-w64-x86_64-openssl mingw-w64-x86_64-sed base-devel autoconf-wrapper autoconf automake libtool make
+
     - name: Install Haskell
       uses: input-output-hk/actions/haskell@latest
       id: setup-haskell
       with:
         ghc-version: ${{ matrix.ghc }}
         cabal-version: "3.12.1.0"
-        pacman-packages: >
-          mingw-w64-x86_64-pkg-config
-          mingw-w64-x86_64-openssl
-          mingw-w64-x86_64-sed
-          base-devel
-          autoconf-wrapper
-          autoconf
-          automake
-          libtool
-          make
 
     - uses: actions/checkout@v4
 

scripts/release-to-chap.sh

@@ -62,7 +62,7 @@ if [[ $REPORT == 1 ]] then
 else
 
   branch=$(git rev-parse --abbrev-ref HEAD)
-  if [[ !($TEST) && !($branch =~ ^(main|release/.*)$) ]]; then
+  if [[ $TEST == 0 && !($branch =~ ^(main|release/.*)$) ]]; then
     echo "error: one must release from main or a release/* branch, pass a -t switch to skip this test"
     exit 1
   fi
@@ -82,7 +82,7 @@ else
     git pull
   fi
   BRANCH="network/release-$(date -I)"
-  if [[ $TEST ]];then
+  if [[ $TEST == 1 ]];then
     BRANCH="${BRANCH}-DO_NOT_MERGE"
   fi
   git switch -c $BRANCH
@@ -103,7 +103,7 @@ else
   git --no-pager log --oneline origin/main..HEAD
 
   popd > /dev/null
-  if [[ !($TEST) ]];then
+  if [[ $TEST == 0 ]];then
     trace "created tags:"
     git tag --points-at=HEAD
     trace "please run ./scripts/build-with-chap.sh"