Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Toggle IP Family Button in the AS Dependency widget #868

Closed
wants to merge 2 commits into from

Conversation

ArnabBCA
Copy link
Member

@ArnabBCA ArnabBCA commented Nov 2, 2024

Description

Added Toggle IP Family Button in the AS Dependency widget

Related issue

Fixes: #865

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@dpgiakatos dpgiakatos self-requested a review November 5, 2024 09:51
@dpgiakatos dpgiakatos changed the title feat: Added Toggle IP Family Button in the "AS Dependency" widget feat: Added Toggle IP Family Button in the AS Dependency widget Nov 6, 2024
Copy link
Member

@dpgiakatos dpgiakatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR addresses the issue on the ASMonitor page; however, the toggle button does not work on the ASCustom page for the ASDependency widget. The author needs to add the functionality there as well. Therefore, this PR requires changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants