Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix activation checkpointing bug #159

Merged
merged 3 commits into from
Oct 9, 2023
Merged

[Fix] Fix activation checkpointing bug #159

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8774a21
fix lora checkpoint bug
LZHgrla Oct 9, 2023
f2163ca
rename
LZHgrla Oct 9, 2023
6bbe164
fix pre-commit
LZHgrla Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions xtuner/model/sft.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,23 +18,14 @@ def __init__(self,
llm,
lora=None,
peft_model=None,
use_gradient_checkpointing=True):
use_activation_checkpointing=True):
super().__init__()
with LoadWoInit():
self.llm = self._build_from_cfg_or_module(llm)
self.llm.config.use_cache = False
dispatch_modules(self.llm)

if isinstance(lora, dict) or isinstance(lora, Config) or isinstance(
lora, ConfigDict):
self.lora = BUILDER.build(lora)
else:
self.lora = lora
self.peft_model = peft_model
self.use_lora = lora is not None
if self.use_lora:
self._prepare_for_lora(peft_model, use_gradient_checkpointing)
elif use_gradient_checkpointing:
if use_activation_checkpointing:
# For backward compatibility
if hasattr(self.llm, 'enable_input_require_grads'):
self.llm.enable_input_require_grads()
Expand All @@ -49,13 +40,23 @@ def make_inputs_require_grad(module, input, output):
# enable gradient checkpointing for memory efficiency
self.llm.gradient_checkpointing_enable()

if isinstance(lora, dict) or isinstance(lora, Config) or isinstance(
lora, ConfigDict):
self.lora = BUILDER.build(lora)
else:
self.lora = lora
self.peft_model = peft_model
self.use_lora = lora is not None
if self.use_lora:
self._prepare_for_lora(peft_model, use_activation_checkpointing)

self._is_init = True

def _prepare_for_lora(self,
peft_model=None,
use_gradient_checkpointing=True):
self.llm = prepare_model_for_kbit_training(self.llm,
use_gradient_checkpointing)
use_activation_checkpointing=True):
self.llm = prepare_model_for_kbit_training(
self.llm, use_activation_checkpointing)
if self.lora.target_modules is None:
modules = find_all_linear_names(self.llm)
self.lora.target_modules = modules
Expand Down