Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 234 redis cache #235

Merged
merged 7 commits into from
Nov 28, 2023
Merged

Issue 234 redis cache #235

merged 7 commits into from
Nov 28, 2023

Conversation

StephanHCB
Copy link
Contributor

@StephanHCB StephanHCB commented Nov 24, 2023

Description

  • introduces go-autumn-sync with both inmemory and redis option
  • use go-autumn-kafka (sarama wrapper) instead of kgo, more flexible, more standardised and offers better debugging. This also adds Azure Event Hub support

Closes #234

Checklist

  • I have read the CONTRIBUTING.md
  • I have made corresponding changes to the documentation
  • My changes generate no lint errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Only MIT licensed or MIT license compatible dependencies are used (e.g.: Apache2 or BSD)
  • The code contains no credentials, personalized data or company secrets

@StephanHCB
Copy link
Contributor Author

Tip: read the commit messages first, I've grouped my changes.

The total diff touches many files just because the cache now is a repository instead of a service (which it should honestly have always been).

KRaffael
KRaffael previously approved these changes Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 163 lines in your changes are missing coverage. Please review.

Comparison is base (98d71b4) 61.08% compared to head (accbcee) 60.43%.

Files Patch % Lines
internal/repository/kafka/kafka.go 0.00% 55 Missing ⚠️
internal/repository/cache/lowlevel.go 40.29% 33 Missing and 7 partials ⚠️
internal/repository/cache/cache.go 58.00% 20 Missing and 1 partial ⚠️
internal/service/services/services.go 33.33% 8 Missing and 2 partials ⚠️
internal/service/repositories/repositories.go 40.00% 6 Missing and 3 partials ⚠️
internal/service/updater/repositories.go 43.75% 6 Missing and 3 partials ⚠️
internal/service/owners/owners.go 53.84% 4 Missing and 2 partials ⚠️
internal/repository/config/accessors.go 33.33% 4 Missing ⚠️
internal/service/updater/owners.go 25.00% 2 Missing and 1 partial ⚠️
internal/service/updater/services.go 25.00% 2 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
- Coverage   61.08%   60.43%   -0.66%     
==========================================
  Files          50       49       -1     
  Lines        5250     5181      -69     
==========================================
- Hits         3207     3131      -76     
+ Misses       1821     1809      -12     
- Partials      222      241      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StephanHCB StephanHCB force-pushed the issue-234-redis-cache branch from 9c7b780 to accbcee Compare November 28, 2023 13:43
@StephanHCB StephanHCB marked this pull request as ready for review November 28, 2023 13:44
@StephanHCB StephanHCB merged commit 3577a07 into main Nov 28, 2023
2 of 4 checks passed
@StephanHCB StephanHCB deleted the issue-234-redis-cache branch November 29, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow redis option for cache
2 participants