Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump github.com/lestrrat-go/jwx/v2 from 2.0.14 to 2.0.15 #218

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 20, 2023

Bumps github.com/lestrrat-go/jwx/v2 from 2.0.14 to 2.0.15.

Release notes

Sourced from github.com/lestrrat-go/jwx/v2's releases.

v2.0.15

v2.0.15 19 20 Oct 2023
[Bug fixes]
  * [jws] jws.Sign() now properly check for valid algorithm / key type pair when
    the key implements crypto.Signer. This was caused by the fact that when 
    jws.WithKey() accepted keys that implemented crypto.Signer, there really
    is no way to robustly check what algorithm the crypto.Signer implements.
The code has now been modified to check for KNOWN key types, i.e. those
that are defined in Go standard library, and those that are defined in
this library. For example, now calling jws.Sign() with jws.WithKey(jwa.RS256, ecdsaKey)
where ecdsaKey is either an instance of *ecdsa.PrivateKey or jwk.ECDSAPrivateKey
will produce an error.

However, if you use a separate library that wraps some KMS library which implements
crypto.Signer, this same check will not be performed due to the fact that
it is an unknown library to us. And there's no way to query a crypto.Signer
for its algorithm family.

Changelog

Sourced from github.com/lestrrat-go/jwx/v2's changelog.

v2.0.15 19 20 Oct 2023 [Bug fixes]

  • [jws] jws.Sign() now properly check for valid algorithm / key type pair when the key implements crypto.Signer. This was caused by the fact that when jws.WithKey() accepted keys that implemented crypto.Signer, there really is no way to robustly check what algorithm the crypto.Signer implements.

    The code has now been modified to check for KNOWN key types, i.e. those that are defined in Go standard library, and those that are defined in this library. For example, now calling jws.Sign() with jws.WithKey(jwa.RS256, ecdsaKey) where ecdsaKey is either an instance of *ecdsa.PrivateKey or jwk.ECDSAPrivateKey will produce an error.

    However, if you use a separate library that wraps some KMS library which implements crypto.Signer, this same check will not be performed due to the fact that it is an unknown library to us. And there's no way to query a crypto.Signer for its algorithm family.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/lestrrat-go/jwx/v2](https://github.com/lestrrat-go/jwx) from 2.0.14 to 2.0.15.
- [Release notes](https://github.com/lestrrat-go/jwx/releases)
- [Changelog](https://github.com/lestrrat-go/jwx/blob/develop/v2/Changes)
- [Commits](lestrrat-go/jwx@v2.0.14...v2.0.15)

---
updated-dependencies:
- dependency-name: github.com/lestrrat-go/jwx/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team October 20, 2023 12:47
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 20, 2023

The following labels could not be found: dependencies.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0d303f8) 60.65% compared to head (78eb1a8) 60.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #218   +/-   ##
=======================================
  Coverage   60.65%   60.65%           
=======================================
  Files          50       50           
  Lines        5162     5162           
=======================================
  Hits         3131     3131           
  Misses       1813     1813           
  Partials      218      218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KRaffael KRaffael merged commit f6c9556 into main Oct 23, 2023
4 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/lestrrat-go/jwx/v2-2.0.15 branch October 23, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant