Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#214): allow operation type LIBRARY #215

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

StephanHCB
Copy link
Contributor

Description

Allows operationType value LIBRARY.

Fixes #214

Checklist

  • I have read the CONTRIBUTING.md
  • I have made corresponding changes to the documentation
  • My changes generate no lint errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Only MIT licensed or MIT license compatible dependencies are used (e.g.: Apache2 or BSD)
  • The code contains no credentials, personalized data or company secrets

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (bf4b643) 60.65% compared to head (45aee47) 60.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   60.65%   60.65%           
=======================================
  Files          50       50           
  Lines        5162     5162           
=======================================
  Hits         3131     3131           
  Misses       1813     1813           
  Partials      218      218           
Files Coverage Δ
internal/service/services/services.go 81.88% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StephanHCB StephanHCB merged commit 29bf1be into main Oct 17, 2023
4 checks passed
@StephanHCB StephanHCB deleted the issue-214-allow-operation-type-library branch October 17, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow operationType LIBRARY for service to make library scaffolding work
2 participants