Merge pull request #323 from Interhyp/deprecations

RELTEC-11165: Remove unused fields
Interhyp · Jul 30, 2024 · e1b316e · e1b316e
2 parents 11d2133 + f8c5b90
commit e1b316e
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 42 deletions.
diff --git a/api/generated_model_ref_protections_branches.go b/api/generated_model_ref_protections_branches.go
diff --git a/api/generated_model_ref_protections_tags.go b/api/generated_model_ref_protections_tags.go
diff --git a/api/generated_model_repository_configuration_dto.go b/api/generated_model_repository_configuration_dto.go
diff --git a/api/generated_model_repository_configuration_patch_dto.go b/api/generated_model_repository_configuration_patch_dto.go
diff --git a/api/openapi-v3-spec.yaml b/api/openapi-v3-spec.yaml
@@ -1930,8 +1930,6 @@ components:
                     testing:
                       - user-one
                       - user-two
-                  defaultReviewers: []
-                  signedApprovers: []
                 timeStamp: '2022-04-18T14:22:38Z'
               unicorn-finder-service.implementation:
                 url: 'ssh://[email protected]:7999/UNICORNS/unicorn-finder-service.git'
@@ -2016,15 +2014,6 @@ components:
             - - someUser
               - anotherUser
               - '@owner.users'
-        defaultReviewers:
-          type: array
-          items:
-            type: string
-        signedApprovers:
-          description: 'List of users, who can sign a pull request.'
-          type: array
-          items:
-            type: string
         archived:
           description: Moves the repository into the archive.
           type: boolean
@@ -2103,15 +2092,6 @@ components:
             - - someUser
               - anotherUser
               - '@owner.users'
-        defaultReviewers:
-          type: array
-          items:
-            type: string
-        signedApprovers:
-          description: 'List of users, who can sign a pull request.'
-          type: array
-          items:
-            type: string
         archived:
           description: Moves the repository into the archive.
           type: boolean

diff --git a/internal/service/repositories/repositories.go b/internal/service/repositories/repositories.go
@@ -3,6 +3,9 @@ package repositories
 import (
 	"context"
 	"fmt"
+	"net/url"
+	"strings"
+
 	"github.com/Interhyp/metadata-service/api"
 	"github.com/Interhyp/metadata-service/internal/acorn/config"
 	"github.com/Interhyp/metadata-service/internal/acorn/repository"
@@ -11,8 +14,6 @@ import (
 	auzerolog "github.com/StephanHCB/go-autumn-logging-zerolog"
 	librepo "github.com/StephanHCB/go-backend-service-common/acorns/repository"
 	"github.com/StephanHCB/go-backend-service-common/api/apierrors"
-	"net/url"
-	"strings"
 )
 
 type Impl struct {
@@ -460,8 +461,6 @@ func patchConfiguration(patch *openapi.RepositoryConfigurationPatchDto, original
 			Webhooks:                patchWebhooks(patch.Webhooks, original.Webhooks),
 			Approvers:               patchApprovers(patch.Approvers, original.Approvers),
 			Watchers:                patchStringSlice(patch.Watchers, original.Watchers),
-			DefaultReviewers:        patchStringSlice(patch.DefaultReviewers, original.DefaultReviewers),
-			SignedApprovers:         patchStringSlice(patch.SignedApprovers, original.SignedApprovers),
 			Archived:                patchPtr[bool](patch.Archived, original.Archived),
 			// fields not allowed for patching carry over from original
 			RequireIssue:      original.RequireIssue,