Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better initialization for wave and shallow water benchmarks #19

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Better initialization for wave and shallow water benchmarks #19

merged 4 commits into from
Nov 11, 2024

Conversation

tkarna
Copy link
Collaborator

@tkarna tkarna commented Nov 7, 2024

  • Replace fromfunction in initialization by reshape and permute_dims
  • Exclude JIT compilation time from timing. This is consistent with other benchmarks.

@tkarna tkarna force-pushed the bye-bye-fromfunction branch from 32d491c to aba4ce8 Compare November 7, 2024 21:18
@tkarna tkarna requested a review from fschlimb November 7, 2024 21:29
fschlimb
fschlimb approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@fschlimb fschlimb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yey!

@tkarna tkarna merged commit 9506c28 into main Nov 11, 2024
2 checks passed
@tkarna tkarna deleted the bye-bye-fromfunction branch November 11, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschlimb fschlimb fschlimb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkarna @fschlimb