Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation steps #45

Merged
merged 15 commits into from
Jul 26, 2024
Merged

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Update Github actions workflow to replace "-c intel" with "-c https://software.repos.intel.com/python/conda" as per solution suggested in IntelPython/mkl_fft#107 (comment)

Update README document accordingly

Copy link
Collaborator

@ekomarova ekomarova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the update-installation-steps branch 2 times, most recently from bb13173 to 2879c1e Compare July 19, 2024 15:22
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the update-installation-steps branch from 2879c1e to 3bd2e33 Compare July 19, 2024 15:24
1. Removed use of vendored numpy.pxd, replaced it with cimport numpy
   to resolve runtime warning during import of change in size of
   broadcast struct
2. Use explicit namespace for NumPy C-API symbols imported by
   Cython. This caught several issues where C-API ndarray object
   was used where Python object of type np.ndarray was intended.
3. Resolve compilation warnings reported by Clang about ignored
   type qualifier during casting.

Local build now passes, import does not report the runtime warning,
and test suite passes.
The helper file defines workaround_PyArray_MultiIter_SIZE, etc
which used NumPy 2.0 API when building with NumPy 2.0, and
a work-around for earlier versions.
@oleksandr-pavlyk oleksandr-pavlyk merged commit 57c45fb into master Jul 26, 2024
17 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the update-installation-steps branch July 26, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants