-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement dpnp.ndarray.__iter__
method
#2206
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev and
vtavana
as code owners
November 29, 2024 20:07
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vlad-perevezentsev
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @antonwolfy !
github-actions bot
added a commit
that referenced
this pull request
Dec 2, 2024
The PR proposes to add implementation of `dpnp.ndarray.__iter__` method. The new code is assumed to be covered by third party tests. - [x] Have you provided a meaningful PR description? - [ ] Have you added a test, reproducer or referred to issue with a reproducer? - [x] Have you tested your changes locally for CPU and GPU devices? - [x] Have you made sure that new changes do not introduce compiler warnings? - [ ] Have you checked performance impact of proposed changes? - [ ] If this PR is a work in progress, are you filing the PR as a draft? 6dbeba9
vtavana
pushed a commit
that referenced
this pull request
Dec 2, 2024
The PR proposes to add implementation of `dpnp.ndarray.__iter__` method. The new code is assumed to be covered by third party tests. - [x] Have you provided a meaningful PR description? - [ ] Have you added a test, reproducer or referred to issue with a reproducer? - [x] Have you tested your changes locally for CPU and GPU devices? - [x] Have you made sure that new changes do not introduce compiler warnings? - [ ] Have you checked performance impact of proposed changes? - [ ] If this PR is a work in progress, are you filing the PR as a draft?
vtavana
pushed a commit
that referenced
this pull request
Dec 2, 2024
The PR proposes to add implementation of `dpnp.ndarray.__iter__` method. The new code is assumed to be covered by third party tests. - [x] Have you provided a meaningful PR description? - [ ] Have you added a test, reproducer or referred to issue with a reproducer? - [x] Have you tested your changes locally for CPU and GPU devices? - [x] Have you made sure that new changes do not introduce compiler warnings? - [ ] Have you checked performance impact of proposed changes? - [ ] If this PR is a work in progress, are you filing the PR as a draft?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to add implementation of
dpnp.ndarray.__iter__
method.The new code is assumed to be covered by third party tests.