Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dpnp.ndarray.__iter__ method #2206

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Nov 29, 2024

The PR proposes to add implementation of dpnp.ndarray.__iter__ method.
The new code is assumed to be covered by third party tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

Copy link
Contributor

github-actions bot commented Nov 29, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy !

@antonwolfy antonwolfy merged commit 6dbeba9 into master Dec 2, 2024
47 of 48 checks passed
@antonwolfy antonwolfy deleted the add-ndarray-iter-method branch December 2, 2024 16:42
github-actions bot added a commit that referenced this pull request Dec 2, 2024
The PR proposes to add implementation of `dpnp.ndarray.__iter__` method.
The new code is assumed to be covered by third party tests.

- [x] Have you provided a meaningful PR description?
- [ ] Have you added a test, reproducer or referred to issue with a
reproducer?
- [x] Have you tested your changes locally for CPU and GPU devices?
- [x] Have you made sure that new changes do not introduce compiler
warnings?
- [ ] Have you checked performance impact of proposed changes?
- [ ] If this PR is a work in progress, are you filing the PR as a
draft? 6dbeba9
vtavana pushed a commit that referenced this pull request Dec 2, 2024
The PR proposes to add implementation of `dpnp.ndarray.__iter__` method.
The new code is assumed to be covered by third party tests.

- [x] Have you provided a meaningful PR description?
- [ ] Have you added a test, reproducer or referred to issue with a
reproducer?
- [x] Have you tested your changes locally for CPU and GPU devices?
- [x] Have you made sure that new changes do not introduce compiler
warnings?
- [ ] Have you checked performance impact of proposed changes?
- [ ] If this PR is a work in progress, are you filing the PR as a
draft?
vtavana pushed a commit that referenced this pull request Dec 2, 2024
The PR proposes to add implementation of `dpnp.ndarray.__iter__` method.
The new code is assumed to be covered by third party tests.

- [x] Have you provided a meaningful PR description?
- [ ] Have you added a test, reproducer or referred to issue with a
reproducer?
- [x] Have you tested your changes locally for CPU and GPU devices?
- [x] Have you made sure that new changes do not introduce compiler
warnings?
- [ ] Have you checked performance impact of proposed changes?
- [ ] If this PR is a work in progress, are you filing the PR as a
draft?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants