Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle dpnp functions and tests to run on CUDA devices #2075

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Handle dpnp functions and tests to run on CUDA devices #2075

wants to merge 30 commits into from
+1,211 −60

Conversation

npolina4
Copy link
Collaborator

@npolina4 npolina4 commented Sep 24, 2024 •
edited by vlad-perevezentsev
Loading

This PR suggests updating some function implementations and tests to run on CUDA devices
The PR includes:

  1. Raise NotImplemetedError for unsupported functions
  2. Create skipped_tests_cuda.tbl for unsupported functions
  3. Skipped tests with a bug ticket for functions that should run on CUDA
  4. Implement is_cuda_backend() and is_cuda_device() to determine that the object has a CUDA backend and that the tests run on CUDA
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions GitHub Actions
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2075/index.html

ndgrigorian
ndgrigorian reviewed Sep 25, 2024
View reviewed changes
dpnp/dpnp_iface.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Sep 26, 2024
View reviewed changes
dpnp/dpnp_iface.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface.py Outdated Show resolved Hide resolved
@npolina4 npolina4 marked this pull request as ready for review September 26, 2024 20:32
antonwolfy
antonwolfy reviewed Oct 16, 2024
View reviewed changes
tests/test_indexing.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Oct 25, 2024
View reviewed changes
dpnp/dpnp_iface.py Outdated Show resolved Hide resolved
tests/third_party/cupy/core_tests/test_dlpack.py Outdated Show resolved Hide resolved
tests/third_party/cupy/statistics_tests/test_meanvar.py Outdated Show resolved Hide resolved
@vlad-perevezentsev vlad-perevezentsev changed the title Apply fallback to numpy for all unsupported functions on cuda devices. Handle dpnp tests to run on CUDA devices Dec 2, 2024
@vlad-perevezentsev vlad-perevezentsev changed the title Handle dpnp tests to run on CUDA devices Handle dpnp functions and tests to run on CUDA devices Dec 2, 2024
@vlad-perevezentsev vlad-perevezentsev self-assigned this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy left review comments

@ndgrigorian ndgrigorian ndgrigorian left review comments

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@npolina4 @ndgrigorian @antonwolfy @vlad-perevezentsev