Changes to private array declarations to use new API in dpex #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adarshyoga can you look at the CI issue? The changes here are fine, but we need the CI to be gree to have full confidence. |
adarshyoga
force-pushed
the
fix/private_arrays
branch
5 times, most recently
from
51252d2 to
4cd34e3
Compare
adarshyoga
force-pushed
the
fix/private_arrays
branch
from
614272c to
aabb25b
Compare
adarshyoga
force-pushed
the
fix/private_arrays
branch
from
3d5a68b to
35ee147
Compare
diptorupd
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes all private array declarations to conform to the latest changes in numba-dpex API for using private arrays.
It also contains a small change dpctl.asarray calls in dpcpp framework, again to conform to changes in dpctl API.