Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure in l2_norm kernel #331

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Fix failure in l2_norm kernel #331

merged 1 commit into from
Feb 7, 2024

Conversation

adarshyoga
Copy link
Contributor

@adarshyoga adarshyoga commented Feb 7, 2024

  • Have you provided a meaningful PR description?

l2_norm workload used numpy.sqrt inside numba_dpex.kernel. Changed it to using math.sqrt since numba_dpex currently supports only the use of explicit scalar operations inside kernel.

  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@adarshyoga adarshyoga requested a review from ZzEeKkAa February 7, 2024 20:15
@adarshyoga adarshyoga self-assigned this Feb 7, 2024
Copy link

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@diptorupd diptorupd merged commit 8b56970 into main Feb 7, 2024
27 of 71 checks passed
@diptorupd diptorupd deleted the fix/l2_norm branch February 7, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants