Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Disable Intel Mac Python package builds #104

Merged
merged 1 commit into from
Dec 11, 2024
Merged

BUG: Disable Intel Mac Python package builds #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
138 changes: 69 additions & 69 deletions .github/workflows/build-test-package-python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,74 +131,74 @@ jobs:
name: LinuxWheel3${{ matrix.python3-minor-version }}${{ matrix.manylinux-platform }}
path: dist/*.whl

build-macos-py:
runs-on: macos-12
strategy:
max-parallel: 2
matrix:
python3-minor-version: ${{ fromJSON(inputs.python3-minor-versions) }}

steps:
- uses: actions/checkout@v3

- name: 'Specific XCode version'
run: |
sudo xcode-select -s "/Applications/Xcode_13.2.1.app"

- name: Get specific version of CMake, Ninja
uses: lukka/[email protected]

- name: 'Fetch build script'
run: |
IPP_DOWNLOAD_GIT_TAG=${{ inputs.itk-python-package-tag }}
IPP_DOWNLOAD_ORG=${{ inputs.itk-python-package-org }}
curl -L https://raw.githubusercontent.com/${IPP_DOWNLOAD_ORG:=InsightSoftwareConsortium}/ITKPythonPackage/${IPP_DOWNLOAD_GIT_TAG:=master}/scripts/macpython-download-cache-and-build-module-wheels.sh -O
chmod u+x macpython-download-cache-and-build-module-wheels.sh

- name: 'Build 🐍 Python 📦 package'
shell: bash
run: |
rm -rf dist

export ITK_PACKAGE_VERSION=${{ inputs.itk-wheel-tag }}
export ITKPYTHONPACKAGE_TAG=${{ inputs.itk-python-package-tag }}
export ITKPYTHONPACKAGE_ORG=${{ inputs.itk-python-package-org }}
export ITK_MODULE_PREQ=${{ inputs.itk-module-deps }}
export MACOSX_DEPLOYMENT_TARGET=10.9
if [ -z ${{ inputs.cmake-options }} ]; then
CMAKE_OPTIONS=""
else
CMAKE_OPTIONS="--cmake_options ${{ inputs.cmake-options }}"
fi
./macpython-download-cache-and-build-module-wheels.sh $CMAKE_OPTIONS "3.${{ matrix.python3-minor-version }}"

- name: Set up Python 3.11 for Validation
uses: actions/setup-python@v5
with:
python-version: "3.11"

- name: Validate build output
shell: bash
run: |
python -m pip install twine
ls dist/

WHEEL_PATTERN="dist/itk_*macosx*.whl"
EXPECTED_WHEEL_COUNT=1

WHEEL_COUNT=`(ls ${WHEEL_PATTERN} | wc -l)`
if (( ${WHEEL_COUNT} != ${EXPECTED_WHEEL_COUNT} )); then
echo "Expected ${EXPECTED_WHEEL_COUNT} wheels but found ${WHEEL_COUNT}"
exit 1
fi

python -m twine check ${WHEEL_PATTERN}

- name: Publish Python package as GitHub Artifact
uses: actions/upload-artifact@v4
with:
name: MacOSWheel3${{ matrix.python3-minor-version }}
path: dist/*.whl
#build-macos-py:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this what is causing a failure in KitwareMedical/HASI#88?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partially (I made a note there).

#runs-on: macos-12
#strategy:
#max-parallel: 2
#matrix:
#python3-minor-version: ${{ fromJSON(inputs.python3-minor-versions) }}

#steps:
#- uses: actions/checkout@v3

#- name: 'Specific XCode version'
#run: |
#sudo xcode-select -s "/Applications/Xcode_13.2.1.app"

#- name: Get specific version of CMake, Ninja
#uses: lukka/[email protected]

#- name: 'Fetch build script'
#run: |
#IPP_DOWNLOAD_GIT_TAG=${{ inputs.itk-python-package-tag }}
#IPP_DOWNLOAD_ORG=${{ inputs.itk-python-package-org }}
#curl -L https://raw.githubusercontent.com/${IPP_DOWNLOAD_ORG:=InsightSoftwareConsortium}/ITKPythonPackage/${IPP_DOWNLOAD_GIT_TAG:=master}/scripts/macpython-download-cache-and-build-module-wheels.sh -O
#chmod u+x macpython-download-cache-and-build-module-wheels.sh

#- name: 'Build 🐍 Python 📦 package'
#shell: bash
#run: |
#rm -rf dist

#export ITK_PACKAGE_VERSION=${{ inputs.itk-wheel-tag }}
#export ITKPYTHONPACKAGE_TAG=${{ inputs.itk-python-package-tag }}
#export ITKPYTHONPACKAGE_ORG=${{ inputs.itk-python-package-org }}
#export ITK_MODULE_PREQ=${{ inputs.itk-module-deps }}
#export MACOSX_DEPLOYMENT_TARGET=10.9
#if [ -z ${{ inputs.cmake-options }} ]; then
#CMAKE_OPTIONS=""
#else
#CMAKE_OPTIONS="--cmake_options ${{ inputs.cmake-options }}"
#fi
#./macpython-download-cache-and-build-module-wheels.sh $CMAKE_OPTIONS "3.${{ matrix.python3-minor-version }}"

#- name: Set up Python 3.11 for Validation
#uses: actions/setup-python@v5
#with:
#python-version: "3.11"

#- name: Validate build output
#shell: bash
#run: |
#python -m pip install twine
#ls dist/

#WHEEL_PATTERN="dist/itk_*macosx*.whl"
#EXPECTED_WHEEL_COUNT=1

#WHEEL_COUNT=`(ls ${WHEEL_PATTERN} | wc -l)`
#if (( ${WHEEL_COUNT} != ${EXPECTED_WHEEL_COUNT} )); then
#echo "Expected ${EXPECTED_WHEEL_COUNT} wheels but found ${WHEEL_COUNT}"
#exit 1
#fi

#python -m twine check ${WHEEL_PATTERN}

#- name: Publish Python package as GitHub Artifact
#uses: actions/upload-artifact@v4
#with:
#name: MacOSWheel3${{ matrix.python3-minor-version }}
#path: dist/*.whl

build-macos-arm-py:
runs-on: macos-14
Expand Down Expand Up @@ -399,9 +399,9 @@ jobs:
publish-python-packages-to-pypi:
needs:
- build-linux-py
- build-macos-py
- build-macos-arm-py
- build-windows-python-packages
#- build-macos-py
runs-on: ubuntu-22.04

steps:
Expand Down