black formatting & pyflakes alerts resolution #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfardet
requested changes
Jan 21, 2025
| @@ -33,8 +33,7 @@ def _add_insee_dep_region(df): | |||
| ) | |||
| df = df.merge(dep, on="insee_reg", how="left") | |||
|
|
|||
| except Exception as e: | |||
| # print(e) | |||
| except Exception: | |||
| pass | |||
There was a problem hiding this comment.
I don't think so, the other exceptions in the same file are already silenced... What do you think?
|
I've just added pre-commits and a mention in the CONTRIBUTING.md. Please double-check this is working as expected, I'm in uncharted waters here 😉 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran pytest and pyflakes on the whole code. I've also cleaned some comment (removed those which seemed unnecessary and kept those I had a doubt on), but that should be marginal.
There are also cases where I was completly sure of what to do, regarding some unused variables. Just to be sure, I flagged those in a different issue.
I suggest merging that PR if possible before merging anything else (I'll clean the current PR resolving github timeouts afterwards for instance).