fix: 404 on delete #337
Merged
fix: 404 on delete #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentC35
added
the
deploy-snapshot
github-actions
bot
removed
the
deploy-snapshot
|
👋 Version 4.10.3-SNAPSHOT deployed on docker hub |
nsenave
reviewed
Jan 22, 2025
| @@ -124,6 +124,6 @@ public void deleteAllVersionsByQuestionnaireIdExceptLast(String poguesId) throws | |||
| (SELECT pv.id FROM pogues_version pv WHERE pv.pogues_id = ? ORDER BY pv."timestamp" desc offset 1 ); | |||
| """; | |||
| int nbVersionsDeleted = jdbcTemplate.update(qString, poguesId); | |||
| if(nbVersionsDeleted == 0) throw new PoguesException(404, "Not found", "No version to delete for poguesId "+ poguesId); | |||
| if(nbVersionsDeleted == 0) log.info("No version to delete for poguesId "+ poguesId); | |||
There was a problem hiding this comment.
string template de slf4j :
log.info("No version to delete for poguesId {}", poguesId)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix tuleap#10499