Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Redefinition of environments #114

Merged
merged 1 commit into from
Sep 25, 2024
Merged

[ENH] Redefinition of environments #114

merged 1 commit into from
Sep 25, 2024

Conversation

clement-dufaure
Copy link
Collaborator

@clement-dufaure clement-dufaure commented Sep 16, 2024 •
edited
Loading

Rewrite environments names with backward compatibility
Addition on new V2 integration and production environment
#109

This was referenced Sep 16, 2024
Closed
Closed
@clement-dufaure clement-dufaure linked an issue Sep 16, 2024 that may be closed by this pull request
[BUG] new endpoints for integration environment #109
Closed
lme-atolcd
lme-atolcd reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@lme-atolcd lme-atolcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.en.md Outdated

Up until version 6.2.0, the extension provided the so-called V1 and V2 environments, which correspond respectively to the historical FranceConnect "standard" and the FranceConnect Plus.

With the addition of the FranceConnect standard V2 and to clear up any ambiguities, the configurations are now named `nSTANDARD_V2` and `PLUS_V2`, while the previous ones will remain available for a few versions to allow for migration. Since the standard V1 offering will be discontinued in 2025, it will not be included in the new naming conventions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: nSTANDARD_V2 → STANDARD_V2

@clement-dufaure
[ENH] Redefinition of environments
57d607d 
Signed-off-by: Clément Dufaure <[email protected]>
@clement-dufaure clement-dufaure force-pushed the add-new-v2-env-and-add-new-names branch from 1f2e02c to 57d607d Compare September 25, 2024 08:48
@clement-dufaure clement-dufaure merged commit 803540d into master Sep 25, 2024
3 checks passed
@clement-dufaure clement-dufaure deleted the add-new-v2-env-and-add-new-names branch September 25, 2024 08:52
@clement-dufaure
Copy link
Collaborator Author

Urls ok, but v2 probably needs more additions like parmeter prompt (in error with my new configuration FC v2 => waiting for FC support response before open issue)

@lme-atolcd
Copy link
Contributor

Tested keycloak-franceconnect 7.0.0 with Keycloak 25.0.6: I was able to login and logout using the INTEGRATION_STANDARD_V2 environment. Thanks for your work.

I confirm that no prompt parameter is added when redirecting the user to the authorize endpoint (https://fcp-low.integ01.dev-franceconnect.fr/api/v2/authorize), but the auth process on the FranceConnect side worked as expected (no error).
I guess that the prompt parameter is not (yet ?) required even if this parameter is tagged as required in the documentation (https://docs.partenaires.franceconnect.gouv.fr/fs/migration/fs-migration-diff-v1-v2/#parametres-d-appel-du-endpoint-authorize)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lme-atolcd lme-atolcd lme-atolcd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] new endpoints for integration environment
2 participants
@clement-dufaure @lme-atolcd