JSON Raw data processing #143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexisszmundy
requested review from
alicela,
loichenninger,
nsenave and
RemiVerriez
nsenave
reviewed
Dec 24, 2024
src/main/java/fr/insee/genesis/controller/dto/rawdata/LunaticJsonRawDataUnprocessedDto.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/insee/genesis/controller/rest/responses/ResponseController.java
Outdated
Show resolved
Hide resolved
| dataCount += surveyUnitModels.size(); | ||
| } | ||
| return ResponseEntity.ok("%d document(s) processed".formatted(dataCount)); | ||
| }catch (GenesisException e){ //TODO replace with spring exception handler |
src/main/java/fr/insee/genesis/controller/utils/ControllerUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/insee/genesis/domain/model/variabletype/VariableTypeModel.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/insee/genesis/domain/service/rawdata/LunaticJsonRawDataService.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Data | ||
| @Document(collection = Constants.MONGODB_VARIABLETYPE_COLLECTION_NAME) | ||
| public class VariableTypeDocument { |
There was a problem hiding this comment.
Si mongo le permet je convertirais bien cette classe aussi en record
There was a problem hiding this comment.
Peut être dans un refacto général des documents
src/test/java/fr/insee/genesis/controller/rest/responses/ResponseControllerTest.java
Show resolved
Hide resolved
…esis-API into devRawDataProcessing
nsenave
reviewed
Jan 21, 2025
src/main/java/fr/insee/genesis/controller/rest/responses/ResponseController.java
Show resolved
Hide resolved
src/main/java/fr/insee/genesis/controller/rest/responses/ResponseController.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/insee/genesis/controller/rest/responses/ResponseController.java
Outdated
Show resolved
Hide resolved
qodana.yaml
Outdated
There was a problem hiding this comment.
stylé d'essayer qodana mais ça pourrait faire l'objet d'une PR indépendante avec la conf des CI etc., ça permettrait aussi de mettre en avant et partager à d'autres équipes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ajout du traitement des données brutes JSON